-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to machine config. #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See slack. |
You may want to do |
I blindly merged and pushed, and I did not test |
snoweye
added a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in the first post of #3. I haven't updated the vignette yet, but the readme is up to date. Check it for an example.
The
rpc()
interface is now has to have a machine argument in it every time, but dealing with multiple machines is much simpler. It might be worth exporting some kind ofset_default_machine(my_machine)
-like function that sets.pbd_env$RPC.LI$machine
or some such. Thenrpc()
(et al) can be modified so that themachine
argument is at the end of the arguments list, and if left blank it would use the.pbd_env
default. This would be nice if you had to deal with one machine a lot I suppose. Another option would be to add an R6 class (or even just fake it with a quick custom job of lists), giving a syntax like:I get the feeling you don't like those interfaces, but I think they're cute. And if we use
Machine()
for the "class" constructor andmachine()
for the regular interface, we could have both at the same time.