Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase mkt_clickid character limit to 255 #1312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dumkydewilde
Copy link

As mentioned in #1311, some of Meta's fbclid parameter values are over 128 characters, causing the events to fail when this parameter is added in the campaign attribution enrichment. This PR increases the character limit from 128 to 255.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@dumkydewilde
Copy link
Author

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

I've signed the CLA 👍

@snowplowcla
Copy link

Confirmed! @dumkydewilde has signed the Contributor License Agreement. Thanks so much.

@snowplowcla snowplowcla added cla:yes and removed cla:no labels Jul 3, 2023
@miike
Copy link
Contributor

miike commented Jul 19, 2023

Thanks @dumkydewilde - we're looking at this at the moment, it may involve bumping this even higher due to some ad networks (e.g., Tiktok) having longer than 255 characters for their ad ids.

@stanch
Copy link

stanch commented Jul 21, 2023

I believe this is more complicated, because the atomic schema is hardcoded in a few places. Currently, you can disable the check as a workaround: https://docs.snowplow.io/docs/pipeline-components-and-applications/enrichment-components/configuration-reference/#enriched-events-validation-against-atomic-schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants