Release R148 #1348
Release R148 #1348
Conversation
matus-tomlein
requested review from
miike,
istreeter,
jbeemster,
igneel64 and
adatzer
| "description": "A parsed version of the user agent detected for the event. Value will be null if the user agent can't be determined.", | ||
| "properties": { | ||
| "mobile": { | ||
| "type": ["boolean", "null"], |
There was a problem hiding this comment.
Just flagging to get confirmation on this:
The user_agent_parsed properties have all been optional. In 1-0-1 version their type was just boolean or string. In version 1-0-2, these properties are still optional, but their type is extended to include "null".
Is this ok for a patch change?
igneel64
force-pushed
the
release/r148
branch
from
f69a54e
to
9cbf83a
Compare
There was a problem hiding this comment.
All looks good to me!
This PR adds an optional field to a couple of existing schemas. We have talked about this before in previous Iglu Central PRs -- it can potentially cause loading issues in the Redshift loader, because of a race condition that we still haven't fixed. In previous Iglu Central releases we decided to go ahead and release the schema anyway, so I think we can do the same thing here.
I guess these mandrill schemas are rarely used -- not many redshift pipelines will have tables for these schemas. So the chance of hitting an error is very very slim.
Even so, we should release it carefully, and watch out for loading errors over the following hours. Any loading error is easily fixed, it's just an annoyance.
matus-tomlein
force-pushed
the
release/r148
branch
from
9cbf83a
to
c5a15a9
Compare
|
Added a schema from @oguzhanunlu that was reviewed in #1350. @istreeter has already approved this and is aware of it being added to the release. |
| }, | ||
| "recoveryTableNames": { | ||
| "description": "List of recovery table names loaded in this batch", | ||
| "type": "array", |
There was a problem hiding this comment.
As this is a new-field doesn't this need to be nullable or does array type implictly imply optionality?
This release add schemas for:
Changelog
Add com.google.ga4/cookies/jsonschema/1-0-0 (#1324)
Add schemas/dev.amp.snowplow/amp_consent/jsonschema/1-0-0 (#1328)
Add com.snowplowanalytics.snowplow/browser_context/jsonschema/2-0-0 (#1330)
Add com.mandrill/recipient_unsubscribed/jsonschema/1-0-2 (#1341)
Add com.mandrill/message_soft_bounced/jsonschema/1-0-2 (#1340)
Add com.mandrill/message_sent/jsonschema/1-0-1 (#1339)
Add com.mandrill/message_rejected/jsonschema/1-0-1 (#1338)
Add com.mandrill/message_opened/jsonschema/1-0-2 (#1337)
Add com.mandrill/message_marked_as_spam/jsonschema/1-0-2 (#1336)
Add com.mandrill/message_delivered/jsonschema/1-0-0 (#1335)
Add com.mandrill/message_delayed/jsonschema/1-0-2 (#1334)
Add com.mandrill/message_clicked/jsonschema/1-0-2 (#1333)
Add com.mandrill/message_bounced/jsonschema/1-0-2 (#1332)