Add integration test for clicks on button children

snowplow · Jan 10, 2024 · a7d7aaf · a7d7aaf
1 parent a377d94
commit a7d7aaf
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/common/changes/@snowplow/javascript-tracker/button-children_2024-01-10-00-47.json b/common/changes/@snowplow/javascript-tracker/button-children_2024-01-10-00-47.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/javascript-tracker",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/javascript-tracker"
+}
diff --git a/trackers/javascript-tracker/test/integration/buttonClick.test.ts b/trackers/javascript-tracker/test/integration/buttonClick.test.ts
@@ -65,6 +65,10 @@ describe('Snowplow Micro integration', () => {
       await (await $('#button7')).click();
       await browser.pause(500);
 
+      // Nested child
+      await (await $('#button-child')).click();
+      await browser.pause(500);
+
       // Disable/enable
 
       await (await $('#disable')).click();
@@ -131,6 +135,11 @@ describe('Snowplow Micro integration', () => {
       logContainsButtonClick(ev);
     });
 
+    it('should get button when click was on a child element', async () => {
+      const ev = makeEvent({ label: 'TestChildren' }, method);
+      logContainsButtonClick(ev);
+    });
+
     it('should not get disabled-click', () => {
       const ev = makeEvent({ id: 'disabled-click', label: 'DisabledClick' }, method);
       expect(logContains(ev)).toBe(false);

diff --git a/trackers/javascript-tracker/test/pages/button-click-tracking.html b/trackers/javascript-tracker/test/pages/button-click-tracking.html
@@ -33,6 +33,9 @@
     <!-- A button that adds a new button dynamically -->
     <button id="addDynamic" onclick="addDynamicButton()">AddButton</button>
 
+    <!-- Ensure button tracked when children are clicked -->
+    <button><span id="button-child">TestChildren</span></button>
+
     <!-- Enable/disable testing -->
     <button id="disable" onclick="snowplow('disableButtonClickTracking')">Disable</button>
     <button id="disabled-click">DisabledClick</button>