Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set the previous session ID reference in cookies if anonymous tracking is enabled (close #1268) #1274

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Do not set the previous session ID reference in cookies if anonymous tracking is enabled (close #1268) #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1d8e83
Do not set the previous session ID reference in cookies if anonymous …
matus-tomlein Dec 12, 2023
40080b6
Run rush change
matus-tomlein Dec 12, 2023
1fc43df
Simplify serializeIdCookie function
matus-tomlein Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...wser-tracker-core/issue-1268-previous_session_id_anonymous_tracking_2023-12-12-13-35.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-tracker-core",
"comment": "Do not set the previous session ID reference in cookies if anonymous tracking is enabled (#1268)",
"type": "none"
}
],
"packageName": "@snowplow/browser-tracker-core"
}
11 changes: 8 additions & 3 deletions libraries/browser-tracker-core/src/tracker/id_cookie.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,14 @@ export function incrementEventIndexInIdCookie(idCookie: ParsedIdCookie) {
* @param idCookie Parsed cookie
* @returns String cookie value
*/
export function serializeIdCookie(idCookie: ParsedIdCookie) {
idCookie.shift();
return idCookie.join('.');
export function serializeIdCookie(idCookie: ParsedIdCookie, configAnonymousTracking: boolean) {
const anonymizedIdCookie: (string | number | undefined)[] = [...idCookie];
if (configAnonymousTracking) {
anonymizedIdCookie[domainUserIdIndex] = '';
anonymizedIdCookie[previousSessionIdIndex] = '';
}
anonymizedIdCookie.shift();
return anonymizedIdCookie.join('.');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion libraries/browser-tracker-core/src/tracker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ export function Tracker(
*/
function setDomainUserIdCookie(idCookie: ParsedIdCookie) {
const cookieName = getSnowplowCookieName('id');
const cookieValue = serializeIdCookie(idCookie);
const cookieValue = serializeIdCookie(idCookie, configAnonymousTracking);
return persistValue(cookieName, cookieValue, configVisitorCookieTimeout);
}

Expand Down
7 changes: 6 additions & 1 deletion libraries/browser-tracker-core/test/id_cookie.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,12 @@ describe('incrementEventIndexInIdCookie', () => {
describe('serializeIdCookie', () => {
it("Doesn't change the original cookie", () => {
let cookie = `def.1653632272.10.1653632282.1653632262.ses.previous.fid.1653632252.9`;
expect(serializeIdCookie(parseIdCookie(cookie, '', '', 0))).toBe(cookie);
expect(serializeIdCookie(parseIdCookie(cookie, '', '', 0), false)).toBe(cookie);
});

it("Doesn't include domain user ID and previous session ID in case of anonymous tracking", () => {
let idCookie = parseIdCookie('def.1653632272.10.1653632282.1653632262.ses.previous.fid.1653632252.9', '', '', 0);
expect(serializeIdCookie(idCookie, true)).toBe('.1653632272.10.1653632282.1653632262.ses..fid.1653632252.9');
});
});

Expand Down
Loading