Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config for callbacks (close #1275) #1276

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Fix config for callbacks (close #1275) #1276

merged 1 commit into from
Dec 13, 2023

Conversation

greg-el
Copy link
Contributor

@greg-el greg-el commented Dec 13, 2023

This PR fixes the onRequestSuccess and onRequestFailure callback params not being present in TrackerConfiguration.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Dec 13, 2023
@greg-el greg-el force-pushed the issue/1275-fix-config-for-callbacks branch 3 times, most recently from 410d507 to e51386e Compare December 13, 2023 14:32
@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 13, 2023 •
edited
Loading

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +25.62KB 26KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +24.74KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +15.05KB 15.5KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.93KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.36KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.51KB 5KB / +10%

Total files change +97.21KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

matus-tomlein
matus-tomlein approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@greg-el greg-el force-pushed the issue/1275-fix-config-for-callbacks branch from 6976260 to 5b983ae Compare December 13, 2023 17:18
@greg-el greg-el merged commit 8a8d357 into release/3.19.0 Dec 13, 2023
2 checks passed
@greg-el greg-el deleted the issue/1275-fix-config-for-callbacks branch December 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

Assignees
No one assigned
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greg-el @matus-tomlein @snowplowcla