Add WebView plugin #1402
Merged
Add WebView plugin #1402
+2,433
−1,823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sorry for reviewing this late, hope it will be possible for you to get some time to check the last few comments, but in case not, let me know and I'll try to help here.
It's working very nicely, but I think we need to change the default of requiring the same tracker namespace on Web as on mobile trackers.
Also after merging the 4.2 branch into master, I kind of messed up your commits 🙈 Can you cherry pick them on top of the latest master?
mscwilson
force-pushed
the
issue/webview_plugin
branch
from
f59f198 to
f1e5f89
Compare
BundleMonFiles added (6)
Total files change +105.95KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Merged
mscwilson
added a commit
that referenced
this pull request
Jan 20, 2025
* Add plugin based on my local webview tracker * Use webview tracker symlink * Correctly parse base64-encoded payloads * Parse string numbers * Add namespaces config option * Remove unused callback * Add docstring * Fix self-desc events * Use actual webview tracker * Run rush change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've manually tested the plugin for iOS and React Native (iOS and Android).
Are there any other unit tests that would be good?
The dependency on the Webview tracker can be updated when the new version is released, it's currently a local dependency.