fix wikipedia-related issues #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubixes
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
I have looked through the code without testing it, and to me it looks good. I don't know exactly about the splits/regex matching, but I trust that you have thought them through and they work for all possible urls/artists. The only thing I have is to remove the notebook, since it won't (hopefully) be used in the future.
There was a problem hiding this comment.
This file should not be in the repository (helpful I'm sure as it was to fix the issues).
There was a problem hiding this comment.
Thanks for your review and for approving the pull request.
I am merging without resolving the issues in the example directory. I will look into making a tests file/directory in a different branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.