Fixed filename too long and empty image file errors, removed redundant example notebooks #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubixes
requested changes
Oct 30, 2023
artscraper/googleart.py
Outdated
| return Path(self.output_dir, paint_id) | ||
| # Prevent problems with too-long file/directory names | ||
| path_str = str(Path(self.output_dir, paint_id)) | ||
| if len(path_str)>=256: |
There was a problem hiding this comment.
If I understand correctly, this gives a directory, right? What is the problem exactly? The /x/y/z, where the whole thing is too long, or only if x or x or z are too long?
What if the output_dir path is already too long?
There was a problem hiding this comment.
I fixed this using SHA-1 hash.
There was a problem hiding this comment.
I think you might want to clear the outputs, just in case.
There was a problem hiding this comment.
I removed the outputs that I thought needed removing.
|
Hi @qubixes : I have made the changes you requested. Does it look okay now? |
|
Hi @qubixes: I have now made the change you requested yesterday (set filename truncation length to 240). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @qubixes , @jgarciab :
I have fixed the issues mentioned in the title. Could you please review my code and accept the pull request if everything looks ok?
Fixes #28 .
Thanks,
Modhurita