Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cum vars #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add cum vars #5

wants to merge 5 commits into from

Conversation

jgarciab
Copy link
Contributor

@jgarciab jgarciab commented Jul 8, 2024

Hi Maarten,

I added all the functionality requested by Max:

  • Type of game
  • Cumulative games (by type of game)
  • Max ELO and max elo faced (by type of game)
  • Random numbers at the game and user name (for filtering)
  • Tournament flag
  • Player title flag
  • Player ELO in bins

Could you take a quick look at it? The data is already been uploaded to surf

maartenschermer
maartenschermer approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@maartenschermer maartenschermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested all changes yet, but looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenschermer maartenschermer maartenschermer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgarciab @maartenschermer