-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Externalize metis #4266
[all] Externalize metis #4266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GKRAND
is rather important if we want to keep the same simulation results across different architectures.
OK. So we can still build our binaries with it by compiling metis from source on the CI and setting |
Co-authored-by: Alex Bilger <[email protected]>
Closed as replaced by #4450 |
Tackles one point of #4221. Required for the conda-forge package (conda-forge/staged-recipes#23085).
Externalize the previously embedded version of metis (5.1.0) which was statically linked.
Provides a cmake module finder file (FindMetis.cmake), tested successfully with the following ways to provide the library:
All on ubuntu 22.04. Not tested with conan.
Some remarks to embed metis in the CI: The embedded version was compiled with GKlib using the
GKRAND
option. To the best of my knowledge, this can be provided either from compiling from source or with the conan package with a specific option.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if