[all] Fix warnings #4291
Merged
[all] Fix warnings #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugtalbot
added
pr: fix
alxbilger
requested changes
Nov 13, 2023
Sofa/Component/LinearSolver/Direct/src/sofa/component/linearsolver/direct/SparseLDLSolver.h
Outdated
Show resolved
Hide resolved
|
[ci-build][with-all-tests] |
alxbilger
approved these changes
Nov 16, 2023
fredroy
added
pr: status wip
|
[ci-build][with-all-tests] |
|
If I recall, Multihreading and SoftRobot scene regressions are not related to this PR |
hugtalbot
added
pr: status to review
hugtalbot
added
the
pr: backport todo
alxbilger
approved these changes
Dec 1, 2023
Co-authored-by: Alex Bilger <[email protected]>
fredroy
force-pushed
the
202311_fix_warnings
branch
from
70e4b05 to
31c9c26
Compare
bakpaul
approved these changes
Dec 1, 2023
hugtalbot
added
pr: status ready
bakpaul
pushed a commit
that referenced
this pull request
Feb 19, 2024
* [all] Fix warnings * revert change on scenes wrongly committed * Apply suggestions from code review Co-authored-by: Alex Bilger <[email protected]> * [all] Fix warnings * Fix runtime error due to useless destructor * take reviews into account: d_nbThreads back to int --------- Co-authored-by: Alex Bilger <[email protected]>
bakpaul
added
pr: backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔽 161 → 86 warnings! (fedora)
🔽 312 → 182 warnings! (ubuntu gcc)
🔥 🔥 🔥
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if