Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cmake option to disable build of runSofa app #4300

Conversation

olivier-roussel
Copy link
Contributor

Title is self-explanatory.
Follows discussion about redefining CI minimal scope.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@olivier-roussel olivier-roussel added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Nov 17, 2023
@alxbilger
Copy link
Contributor

There is already APPLICATION_RUNSOFA. It defined implicitly when you do sofa_add_subdirectory(application runSofa runSofa ON)

@hugtalbot hugtalbot added the STC#16 Tasks for STC#16 coding sprint label Nov 17, 2023
@olivier-roussel
Copy link
Contributor Author

Indeed... I guess I misunderstood what has been said yesterday.

@hugtalbot hugtalbot removed the pr: status to review To notify reviewers to review this pull-request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature STC#16 Tasks for STC#16 coding sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants