Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image] Merge CImgPlugin into image #4303

Closed
wants to merge 9 commits into from
Closed

[image] Merge CImgPlugin into image #4303

wants to merge 9 commits into from

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Nov 17, 2023

As CImgPlugin became almost useless for loading images (jpg, etc #2551 ), its only usage is to ship cimg.
So it would make sense to put it back in image (which is the main user of the lib cimg)

Fix #4299

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code pr: clean Cleaning the code labels Nov 17, 2023
@hugtalbot hugtalbot added the STC#16 Tasks for STC#16 coding sprint label Nov 17, 2023
@hugtalbot hugtalbot added this to the v24.06 milestone Nov 22, 2023
@fredroy
Copy link
Contributor Author

fredroy commented Nov 28, 2023

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy added pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Dec 6, 2023
@fredroy
Copy link
Contributor Author

fredroy commented Jan 7, 2024

Not necessary for the moment...

@fredroy fredroy closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. pr: status wip Development in the pull-request is still in progress refactoring Refactor code STC#16 Tasks for STC#16 coding sprint
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.

Merge CImg and image
2 participants
@fredroy @hugtalbot