[SofaSPHFluid] Add option in ParticleSource to add/remove random values in the particles generation. Remove noise for CI scenes #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: fix
|
[ci-build][with-all-tests] |
epernod
force-pushed
the
inf_2023_21_fix_sph_regression
branch
from
df35de6 to
f2aa7ad
Compare
epernod
added
pr: status wip
epernod
force-pushed
the
inf_2023_21_fix_sph_regression
branch
from
92c9152 to
b5cc3ce
Compare
epernod
changed the title
epernod
added
pr: status to review
epernod
changed the title
bakpaul
approved these changes
Feb 14, 2024
hugtalbot
approved these changes
Feb 14, 2024
alxbilger
approved these changes
Feb 14, 2024
hugtalbot
added
pr: status ready
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Feb 23, 2024
…es in the particles generation. Remove noise for CI scenes (sofa-framework#4316) * [src] Add noise option in ParticleSource * [SPH][scenes] Update scene under regression test not to use noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option in ParticleSource to add random values in the particles generation.
Remove this option in the default scenes for the CI
[ci-depends-on https://github.com/https://github.com/sofa-framework/Regression/pull/58]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if