Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinearAlgebra] constexpr if statement when possible #4352

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[LinearAlgebra] constexpr if statement when possible #4352

merged 2 commits into from
Dec 14, 2023

Conversation

alxbilger
Copy link
Contributor

transpose and add are known at compile-time, so a constexpr if can be used to evaluate them, and discard statements.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Dec 12, 2023
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: status to review To notify reviewers to review this pull-request labels Dec 13, 2023
@fredroy fredroy force-pushed the constexprifbasematrix branch from 3cb3aeb to 2cbbd21 Compare December 14, 2023 03:35
@fredroy fredroy merged commit 8774d29 into sofa-framework:master Dec 14, 2023
2 checks passed
@hugtalbot hugtalbot added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 10, 2024
@hugtalbot hugtalbot added this to the v24.06 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @bakpaul @fredroy @hugtalbot