[CImgPlugin] Add fetchable CImg and remove embedded cimg #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
alxbilger
approved these changes
Dec 13, 2023
|
+200k lines removed = 💟 |
|
[ci-build][with-all-tests][force-full-build] |
bakpaul
approved these changes
Dec 20, 2023
hugtalbot
added
pr: status ready
hugtalbot
added
pr: backport todo
hugtalbot
pushed a commit
to hugtalbot/sofa
that referenced
this pull request
Jan 16, 2024
…ork#4357) * support interface-type for auto_target_properties install macro * try updating install macro * try updating install macro again * use (only) find_package for CImg * fix image compilation for newer version of cimg * remove cimg src * export mutex symbol with a .def file for windows * add comment * add fetchable cimg * fix packaging * fix image_gui * fix image_type comparison --------- Co-authored-by: erik pernod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
Remove the (really old) cimg version and fetch it from cimg git repository (or let the user set-up its own cimg version.
Not a requirement for #4221 anyway (header-only are acceptable)
declspecshenanigans on MSVC 🫠 As the current cimg.h file has been modified to add a export symbol macro...)(compiles with the cimg provided by Ubuntu v22.04 and latest cimg on Windows)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if