[Core] BaseMapping: link mapConstraints to the "meta-alias" isMechanical #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
enhancement
|
[ci-build][with-all-tests] |
hugtalbot
approved these changes
Dec 20, 2023
hugtalbot
added
pr: status ready
alxbilger
approved these changes
Dec 20, 2023
epernod
force-pushed
the
mapping_is_mechanical
branch
from
2274b37 to
44b2d1e
Compare
hugtalbot
added
pr: backport todo
hugtalbot
pushed a commit
to hugtalbot/sofa
that referenced
this pull request
Jan 16, 2024
…cal (sofa-framework#4360) add mapConstraints to the meta-alias isMechanical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setMechanical() and isMechanical() use the boolean states of forces, masses and constraints.
But the "meta-alias"(?)
isMechanicalonly link forces and masses. So it would make sense to add constraints 🤔Avoid cases like fredroy/BeamAdapter@58b3db1
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if