[Topology.Mapping] Edge2QuadTopologicalMapping: use Links for required QuadSet components #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
fredroy
force-pushed
the
edge2quad_uselinks
branch
from
7392769 to
f61e74b
Compare
|
[ci-build][with-all-tests] |
alxbilger
approved these changes
Dec 15, 2023
| @@ -31,6 +31,13 @@ | |||
| #include <sofa/core/BaseMapping.h> | |||
| #include <sofa/core/behavior/MechanicalState.h> | |||
|
|
|||
|
|
|||
| namespace sofa::component::topology::container::dynamic | |||
There was a problem hiding this comment.
I am surprised that forward declaration works with Links
There was a problem hiding this comment.
I wanted to try for the lolz but it works on MSVC. Curious to see if it will be the same for gcc/clang (if the CI does want to do its job) 😅
EDIT: it works too 👍
bakpaul
approved these changes
Dec 15, 2023
|
[ci-build][with-all-tests] |
hugtalbot
added
pr: status ready
hugtalbot
added
pr: backport todo
hugtalbot
pushed a commit
to hugtalbot/sofa
that referenced
this pull request
Jan 16, 2024
…d QuadSet components (sofa-framework#4361) * use links for quad container/modifier * cleaning --------- Co-authored-by: Paul Baksic <[email protected]> Co-authored-by: erik pernod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge2QuadTopologicalMapping needs QuadSet container and modifier, and was merely just searching into its node for them, with no check whatsoever. So if one of the two was not present, a crash happened without any warning/error...
So in this PR, links are added (so no need to search the context every time), warn the user if not set and let the component to Invalid
+ some cleanups for good measure
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if