-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sofa.Testing] Do not build Sofa.Testing if SOFA_BUILD_TESTS is OFF #4459
[Sofa.Testing] Do not build Sofa.Testing if SOFA_BUILD_TESTS is OFF #4459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. In a similar manner, the .Testing
modules in Sofa.Component
also depend on the variable SOFA_BUILD_TESTS
:
In Sofa/Component/Engine/CMakeLists.txt:
if(SOFA_BUILD_TESTS)
add_subdirectory(Testing)
endif()
As we just discussed, let's wait if #4471 is fine, in which case this PR should be closed and discarded: we would keep building Sofa.Testing component even if TU are not built ( |
Any reason to have re-opened this ? I thought we all agreed that this PR would be discarded and closed as the initial behavior of having Sofa.Testing built for other plugins TU is OK and the problem with conda was fixed thanks to #447. |
Note meeting 28/02/2024 : Sofa.Testing should externalized in order to bring real modularization |
... unless there is a good reason to keep built even if tests are not built ?
In the case we have to keep it built, we will have to handle the embedded dependency google test (linked dynamically), probably in a similar manner than other libs such as metis (find package or fetch code and link dynamically).
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if