Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Apply nested namespaces #4482

Merged
merged 4 commits into from
Feb 22, 2024
Merged

[all] Apply nested namespaces #4482

merged 4 commits into from
Feb 22, 2024

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 7, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

alxbilger
alxbilger commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To revert: Sofa/GUI/Batch/src/sofa/gui/batch/indicators/indicators.hpp

@bakpaul bakpaul added this to the v24.06 milestone Feb 20, 2024
@bakpaul
Copy link
Contributor

bakpaul commented Feb 21, 2024

[ci-build][with-all-tests]

@fredroy
Copy link
Contributor

fredroy commented Feb 22, 2024

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 22, 2024
@fredroy fredroy merged commit 57e91ce into sofa-framework:master Feb 22, 2024
14 of 15 checks passed
bakpaul pushed a commit to bakpaul/sofa that referenced this pull request Feb 23, 2024
@alxbilger
[all] Apply nested namespaces (sofa-framework#4482)
e226c7d 
* [all] Apply nested namespaces

* Fix compilation

* Revert nested namespaces on .cu files to fix compilation

* Fix bad refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot left review comments

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @bakpaul @fredroy @hugtalbot