Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Fix installation of gtest headers #4489

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[Testing] Fix installation of gtest headers #4489

merged 1 commit into from
Feb 9, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 9, 2024

... or so it seems.

There is not CI process for the install process and I could compile BeamAdapter_test target out of tree, but I would prefer if other people could test it 🧐

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 9, 2024
@alxbilger
Copy link
Contributor

🤞

@alxbilger alxbilger merged commit 50a0228 into sofa-framework:master Feb 9, 2024
18 checks passed
@fredroy fredroy deleted the fix_gtest_header_install branch February 9, 2024 09:22
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2024
bakpaul pushed a commit that referenced this pull request Feb 27, 2024
@fredroy @bakpaul
[Testing] Fix installation of gtest headers (#4489)
460312f 
fix gtest headers install
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @alxbilger @hugtalbot @bakpaul