Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] POC: enable assertions even in release mode #4496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 13, 2024

⚠️ DO NOT MERGE ! ⚠️

The CI only compiles in debug for one configuration and only when a commit is done on the master.
AND a lot of failures just happen because of timeouts. So the readings are uncomfortable, to say the least

So This PR simply enable assertions in release mode (overriding the flags) and should show where the assertions happen,


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Feb 13, 2024
@fredroy fredroy marked this pull request as draft February 13, 2024 07:58
@fredroy
Copy link
Contributor Author

fredroy commented Feb 13, 2024

[ci-build][with-all-tests][force-full-build]

1 similar comment
@fredroy
Copy link
Contributor Author

fredroy commented Feb 13, 2024

[ci-build][with-all-tests][force-full-build]

@hugtalbot hugtalbot added the STC#17 Tasks for STC#17 coding sprint label Feb 14, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch 2 times, most recently from c444e8f to 93b73f3 Compare February 22, 2024 00:56
@fredroy
Copy link
Contributor Author

fredroy commented Feb 22, 2024

[ci-build][with-all-tests]

@fredroy fredroy removed the topic for next dev-meeting PR to be discussed in sofa-dev meeting label Feb 23, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch from 93b73f3 to a258b44 Compare February 23, 2024 02:50
@fredroy
Copy link
Contributor Author

fredroy commented Feb 23, 2024

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the poc_release_with_assert branch from a258b44 to 99efa31 Compare February 28, 2024 14:58
@fredroy fredroy force-pushed the poc_release_with_assert branch 2 times, most recently from eb6ffbc to 81cee92 Compare March 26, 2024 01:05
@fredroy
Copy link
Contributor Author

fredroy commented Mar 26, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy force-pushed the poc_release_with_assert branch from 4cdf7fe to 07a63e2 Compare March 27, 2024 00:04
@fredroy fredroy closed this Mar 27, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch from 07a63e2 to aa1e30a Compare March 27, 2024 00:56
@fredroy fredroy reopened this Mar 27, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Mar 27, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy force-pushed the poc_release_with_assert branch from 967fc3a to b7367e9 Compare April 1, 2024 02:50
@fredroy
Copy link
Contributor Author

fredroy commented Apr 1, 2024

[ci-build][with-all-tests][force-full-build]

1 similar comment
@fredroy
Copy link
Contributor Author

fredroy commented Apr 4, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Apr 4, 2024

[ci-depends-on] detected during build #21.

To unlock the merge button, you must

@fredroy fredroy force-pushed the poc_release_with_assert branch from b7367e9 to 4340f63 Compare April 24, 2024 00:58
@sofabot
Copy link
Collaborator

sofabot commented Apr 24, 2024

[ci-depends-on] detected during build #22.

To unlock the merge button, you must

@fredroy fredroy force-pushed the poc_release_with_assert branch from 4340f63 to 8879008 Compare July 18, 2024 05:00
@fredroy fredroy force-pushed the poc_release_with_assert branch from 8879008 to 342cf7a Compare July 30, 2024 01:30
@fredroy fredroy removed the pr: status wip Development in the pull-request is still in progress label Aug 9, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch from 342cf7a to 2838366 Compare August 9, 2024 00:48
@fredroy fredroy force-pushed the poc_release_with_assert branch from 2838366 to df9919b Compare September 10, 2024 01:22
@fredroy
Copy link
Contributor Author

fredroy commented Sep 10, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy force-pushed the poc_release_with_assert branch from df9919b to 98b82fc Compare October 14, 2024 00:41
@fredroy
Copy link
Contributor Author

fredroy commented Oct 14, 2024

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy force-pushed the poc_release_with_assert branch from 98b82fc to 06913d9 Compare November 21, 2024 01:38
@fredroy fredroy removed the STC#17 Tasks for STC#17 coding sprint label Nov 21, 2024
@fredroy fredroy force-pushed the poc_release_with_assert branch from 06913d9 to 5e6b7a4 Compare December 16, 2024 06:44
@fredroy fredroy force-pushed the poc_release_with_assert branch from 5e6b7a4 to 8a32ce6 Compare January 12, 2025 23:26
@fredroy
Copy link
Contributor Author

fredroy commented Jan 12, 2025

[ci-build][with-all-tests][force-full-build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants