Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Deprecate typeName with parameter #4817

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[Core] Deprecate typeName with parameter #4817

merged 2 commits into from
Jul 11, 2024

Conversation

alxbilger
Copy link
Contributor

The parameter is not used in the function. Only its type. The parameter is here probably just for template deduction. I suggest to remove the use of a parameter. Reason in #4816

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jul 10, 2024
@fredroy fredroy force-pushed the deprecatetypename branch from 099a254 to fa05293 Compare July 11, 2024 00:21
@fredroy fredroy added the pr: clean Cleaning the code label Jul 11, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 11, 2024
@fredroy fredroy merged commit 3bfaa78 into sofa-framework:master Jul 11, 2024
16 of 17 checks passed
@hugtalbot hugtalbot added this to the v24.12 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.12
Development

Successfully merging this pull request may close these issues.
3 participants
@alxbilger @fredroy @hugtalbot