Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Test json dump on the main object factory #4818

Merged
merged 4 commits into from
Jul 17, 2024
Merged

[Core] Test json dump on the main object factory #4818

merged 4 commits into from
Jul 17, 2024

Conversation

alxbilger
Copy link
Contributor

Requires other PRs to avoid crashes during the dump

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: test PR adding test(s) in SOFA labels Jul 10, 2024
@alxbilger alxbilger force-pushed the testobjectfactory branch from 2177b57 to 43e405f Compare July 12, 2024 08:06
@fredroy fredroy force-pushed the testobjectfactory branch from 43e405f to 29f300e Compare July 15, 2024 06:08
@alxbilger alxbilger force-pushed the testobjectfactory branch 2 times, most recently from 03e9e73 to 8e7d28e Compare July 16, 2024 08:17
@alxbilger alxbilger force-pushed the testobjectfactory branch from 4eee378 to 48b8b06 Compare July 16, 2024 12:45
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 17, 2024
@hugtalbot hugtalbot merged commit bb21ea0 into sofa-framework:master Jul 17, 2024
9 of 11 checks passed
@hugtalbot hugtalbot added this to the v24.12 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: status ready Approved a pull-request, ready to be squashed pr: test PR adding test(s) in SOFA
Projects
No open projects
Updated and automated documentation
Status: No status
Milestone
v24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@alxbilger @hugtalbot