Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sofa.GL] OglModel: Deprecate/Remove isEnabled Data #4822

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jul 11, 2024

added a enabled data for all VisualModels

OglModel already had a data with the same feature (isEnabled) so this PR removes it.
Breaking because of the removal of the Data isEnabled (change of type) so the code using it as a Data will break,


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 11, 2024
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests]

@fredroy fredroy force-pushed the remove_oglmodel_enabled branch 3 times, most recently from 4674d84 to 9aaffa8 Compare July 24, 2024 05:18
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 24, 2024
@fredroy fredroy force-pushed the remove_oglmodel_enabled branch from 9aaffa8 to 39f1cd5 Compare July 25, 2024 10:34
@fredroy fredroy force-pushed the remove_oglmodel_enabled branch from 39f1cd5 to b957a5a Compare July 25, 2024 13:30
@hugtalbot hugtalbot merged commit 298e146 into sofa-framework:master Jul 25, 2024
11 checks passed
@hugtalbot hugtalbot deleted the remove_oglmodel_enabled branch July 25, 2024 18:37
@hugtalbot hugtalbot added this to the v24.12 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants