Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playback] Apply new factory registration mechanism #4933

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[Playback] Apply new factory registration mechanism #4933

merged 4 commits into from
Sep 5, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Aug 22, 2024

See

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Aug 22, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Aug 22, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 4, 2024
@hugtalbot
Copy link
Contributor

hugtalbot commented Sep 4, 2024 •
edited
Loading

please check my commit fixing the minor conflict @fredroy 👇

@epernod epernod merged commit 0830f4c into sofa-framework:master Sep 5, 2024
11 checks passed
@fredroy fredroy deleted the register_playback branch September 24, 2024 04:22
@hugtalbot hugtalbot added this to the v24.12 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@epernod epernod epernod approved these changes

@bakpaul bakpaul bakpaul approved these changes

Assignees
No one assigned
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v24.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @hugtalbot @epernod @bakpaul