Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mapping] Apply new factory registration mechanism #5053

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Oct 10, 2024

See

[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/463]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 10, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Oct 10, 2024

[ci-build][with-all-tests]

@sofabot
Copy link
Collaborator

sofabot commented Oct 11, 2024

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@fredroy
Copy link
Contributor Author

fredroy commented Oct 11, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Oct 11, 2024

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@fredroy
Copy link
Contributor Author

fredroy commented Oct 11, 2024

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Oct 11, 2024

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Oct 21, 2024

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Oct 24, 2024

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Oct 26, 2024

[ci-depends-on] detected during build #8.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 26, 2024
@epernod epernod merged commit e6b98de into sofa-framework:master Oct 26, 2024
14 of 15 checks passed
@hugtalbot hugtalbot modified the milestones: v25.06, v24.12 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants