-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backward] Fix trapezoidal rule in EulerImplicitSolver #5169
[Backward] Fix trapezoidal rule in EulerImplicitSolver #5169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what I have for Backward Euler:
and for the trapezoidal rule:
So, your changes make sense to me
[ci-build][with-all-tests] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make a PR on Regression and add a ci-depends-on ?
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #8. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #9. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
[ci-depends-on] detected during build #10. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
Fix #5140
Pendulum__r60_0002.mp4
NB: it would be nice to have the image of the issue added (as text) in the doc
[ci-depends-on https://github.com/sofa-framework/Regression/pull/74]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if