[All] Remove last deprecated VecId and use constexpr vecids #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
|
[ci-build][with-all-tests] |
fredroy
force-pushed
the
convert_constexpr_vecid
branch
from
f7ba04d to
a981fd7
Compare
alxbilger
approved these changes
Jan 10, 2025
bakpaul
reviewed
Jan 20, 2025
| @@ -1032,7 +1032,7 @@ void MechanicalObject<DataTypes>::init() | |||
| //case if X0 has been set but not X | |||
| if (read(core::vec_id::read_access::restPosition)->getValue().size() > x_wA.size()) | |||
| { | |||
| vOp(core::execparams::defaultInstance(), core::VecId::position(), core::VecId::restPosition()); | |||
| vOp(core::execparams::defaultInstance(), sofa::core::vec_id::write_access::position, sofa::core::vec_id::read_access::restPosition); | |||
There was a problem hiding this comment.
One is write and the other one is read, is that correct (seem right to me, we don't want to override the restPosition, but I prefer asking)
There was a problem hiding this comment.
yes
first vecid is writable, next ones are read-only vecid
Sofa/Component/StateContainer/src/sofa/component/statecontainer/MechanicalObject.inl
Show resolved
Hide resolved
Sofa/Component/StateContainer/src/sofa/component/statecontainer/MechanicalObject.inl
Show resolved
Hide resolved
Sofa/Component/StateContainer/src/sofa/component/statecontainer/MechanicalObject.inl
Show resolved
Hide resolved
Sofa/Component/StateContainer/src/sofa/component/statecontainer/MechanicalObject.inl
Show resolved
Hide resolved
fredroy
force-pushed
the
convert_constexpr_vecid
branch
from
86ffe66 to
5de59d1
Compare
fredroy
force-pushed
the
convert_constexpr_vecid
branch
from
5de59d1 to
151faaa
Compare
bakpaul
approved these changes
Jan 22, 2025
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done with Find/Replace dumbly because some functions were using the "write" access when they need a read access only.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if