[GL] OglSceneFrame: fix background #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
|
Not sure about keeping the old behavior |
hugtalbot
approved these changes
Jan 16, 2025
alxbilger
requested changes
Jan 16, 2025
Sofa/GL/Component/Rendering3D/src/sofa/gl/component/rendering3d/OglSceneFrame.cpp
Outdated
Show resolved
Hide resolved
bakpaul
approved these changes
Jan 16, 2025
fredroy
force-pushed
the
background_sceneframe
branch
from
0c3f442 to
d2cf117
Compare
bakpaul
added
pr: status ready
epernod
added
the
pr: fast merge
epernod
approved these changes
Jan 22, 2025
epernod
force-pushed
the
background_sceneframe
branch
from
d2cf117 to
f27189d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The (scissored) viewport of the oglsceneframe clears its backbuffer so if a texture has been set in the background (typically by the GUI) it does produce a solid background behind ; which was weird to me.
This PR fixes it by disabling the clearing of the backbuffer.
But I dont know if it was intended at the creation of this component. So I add a Data if one wants the legacy behavior (but the legacy behavior is unset by default)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if