-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to koupleless #139
update to koupleless #139
Conversation
您的邮件已经收到,会在看到第一时间回复您,祝您生活愉快。
|
WalkthroughThe project has transitioned from maintenance mode with features integrated into SOFAArk to endorsing Koupleless. This shift is highlighted in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
README.md (3)
Line range hint
45-53
: Consider replacing the informal term 'Biz' with a more formal alternative.- Ark Biz + Ark Business ModuleThis change should be applied consistently wherever 'Biz' is used in the document to maintain a professional tone.
Line range hint
79-79
: Add a colon after "Jarslink 开发参与说明书" for clarity and consistency.- + [代码贡献](./CONTRIBUTING.md): Jarslink 开发参与说明书 + + [代码贡献](./CONTRIBUTING.md): Jarslink 开发参与说明书:
Line range hint
74-77
: Standardize the list marker style in the document.- * [如何创建 SOFABoot 应用](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-app-demo) - * [如何使用 Jarslink 多应用动态部署](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-deploy-demo) - * [如何使用跨应用通信](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-invocation-demo) - * [如何集成 SOFABoot 健康检查](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-health-demo) + + [如何创建 SOFABoot 应用](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-app-demo) + + [如何使用 Jarslink 多应用动态部署](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-deploy-demo) + + [如何使用跨应用通信](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-invocation-demo) + + [如何集成 SOFABoot 健康检查](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-health-demo)
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional Context Used
LanguageTool (6)
README.md (6)
Near line 8: You might be missing the article “the” here.
Context: ...thub.com/sofastack/sofa-ark) as part of modular development framework [Koupleless](http...
Near line 45: The word ‘Biz’ is informal. Consider replacing it.
Context: ...假设你已经对 SOFAArk 有一定的了解,很容易知道,应用被打包成 [Ark Biz](http://www.sofastack.tech/sofa-boot/do...
Near line 45: The word ‘Biz’ is informal. Consider replacing it.
Context: ... 应用,甚至普通的模块都可以借助 SOFAArk 插件打包成一个标准的 Ark Biz 包。 Jarslink2.0 支持多个 Ark Biz 运行在 SOFAAr...
Near line 47: The word ‘Biz’ is informal. Consider replacing it.
Context: ...成一个标准的 Ark Biz 包。 Jarslink2.0 支持多个 Ark Biz 运行在 SOFAArk 容器之上,从而做到多应用的合并部署。应用可以通过注解的...
Near line 53: The word ‘Biz’ is informal. Consider replacing it.
Context: ...k2.0 核心代码,支持动态接收命令,如安装、卸载、切换等等,用于管理 Ark Biz 的生命周期。如果需要运行时动态部署应用,需要添加如下依赖: ```xml <d...
Near line 79: A punctuation mark might be missing here.
Context: ...ofa-jarslink-jarslink-health-demo) # 贡献 + 代码贡献: Jarslink 开发参与说...
Additional comments not posted (1)
README.md (1)
8-10
: Update the project description to reflect the shift to Koupleless.The updated project description accurately reflects the shift from SOFAArk to Koupleless, aligning with the PR objectives and AI-generated summary.
@@ -5,9 +5,9 @@ | |||
![license](https://img.shields.io/badge/license-Apache--2.0-green.svg) | |||
![maven](https://img.shields.io/nexus/s/https/oss.sonatype.org/com.alipay.sofa/sofa-jarslink.svg) | |||
|
|||
This project is no longer in active development, and is currently in maintenance mode. All the existing features have been merged into [SOFAArk](https://github.com/sofastack/sofa-ark) and we highly recommend that you use [SOFAArk](https://github.com/sofastack/sofa-ark) instead. | |||
This project is no longer in active development, and is currently in maintenance mode. All the existing features have been merged into [SOFAArk](https://github.com/sofastack/sofa-ark) as part of modular development framework [Koupleless](https://koupleless.io), and we highly recommend that you use **[Koupleless](https://koupleless.io)** instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding the definite article "the" for grammatical correctness.
- as part of modular development framework [Koupleless](https://koupleless.io)
+ as part of the modular development framework [Koupleless](https://koupleless.io)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
This project is no longer in active development, and is currently in maintenance mode. All the existing features have been merged into [SOFAArk](https://github.com/sofastack/sofa-ark) as part of modular development framework [Koupleless](https://koupleless.io), and we highly recommend that you use **[Koupleless](https://koupleless.io)** instead. | |
This project is no longer in active development, and is currently in maintenance mode. All the existing features have been merged into [SOFAArk](https://github.com/sofastack/sofa-ark) as part of the modular development framework [Koupleless](https://koupleless.io), and we highly recommend that you use **[Koupleless](https://koupleless.io)** instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
README.md (2)
Line range hint
45-53
: Consider replacing the informal term 'Biz' with a more formal alternative.The term 'Biz' might be seen as too informal for documentation. Consider using 'Business' or another formal term.
- Ark Biz + Ark Business
Line range hint
74-77
: Adjust the list style for consistency.The list uses asterisks instead of plus signs, which is inconsistent with other lists in the document.
- * [如何创建 SOFABoot 应用](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-app-demo) - * [如何使用 Jarslink 多应用动态部署](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-deploy-demo) - * [如何使用跨应用通信](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-invocation-demo) - * [如何集成 SOFABoot 健康检查](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-health-demo) + + [如何创建 SOFABoot 应用](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-app-demo) + + [如何使用 Jarslink 多应用动态部署](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-deploy-demo) + + [如何使用跨应用通信](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-invocation-demo) + + [如何集成 SOFABoot 健康检查](http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-health-demo)
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional Context Used
LanguageTool (4)
README.md (4)
Near line 45: The word ‘Biz’ is informal. Consider replacing it.
Context: ...假设你已经对 SOFAArk 有一定的了解,很容易知道,应用被打包成 [Ark Biz](http://www.sofastack.tech/sofa-boot/do...
Near line 45: The word ‘Biz’ is informal. Consider replacing it.
Context: ... 应用,甚至普通的模块都可以借助 SOFAArk 插件打包成一个标准的 Ark Biz 包。 Jarslink2.0 支持多个 Ark Biz 运行在 SOFAAr...
Near line 47: The word ‘Biz’ is informal. Consider replacing it.
Context: ...成一个标准的 Ark Biz 包。 Jarslink2.0 支持多个 Ark Biz 运行在 SOFAArk 容器之上,从而做到多应用的合并部署。应用可以通过注解的...
Near line 53: The word ‘Biz’ is informal. Consider replacing it.
Context: ...k2.0 核心代码,支持动态接收命令,如安装、卸载、切换等等,用于管理 Ark Biz 的生命周期。如果需要运行时动态部署应用,需要添加如下依赖: ```xml <d...
Additional comments not posted (2)
README.md (2)
8-10
: Update the project description to reflect the shift to Koupleless.The changes correctly update the project's status and recommendation, aligning with the PR's objectives to shift focus from SOFAArk to Koupleless.
8-8
: Consider adding the definite article "the" for grammatical correctness.This suggestion was previously made and is still valid.
- as part of modular development framework [Koupleless](https://koupleless.io) + as part of the modular development framework [Koupleless](https://koupleless.io)
Summary by CodeRabbit