feat:add Bidistreaming Api #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HHoflittlefish777, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
sofastack-bot
bot
added
cla:no
First-time contributor
size/XXL
cla:yes
and removed
cla:no
labels
fengjiachun
reviewed
Oct 11, 2022
| @Override | ||
| public StreamObserver<Message> invokeBidiStreaming(Endpoint endpoint, Object request, InvokeContext ctx, | ||
| InvokeCallback callback, long timeoutMs) { | ||
| return null; |
There was a problem hiding this comment.
可以 throw 一个 UnsupportedException 之类的 error
| @@ -119,6 +122,12 @@ public void invokeAsync(final Endpoint endpoint, final Object request, final Inv | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public StreamObserver<Message> invokeBidiStreaming(Endpoint endpoint, Object request, InvokeContext ctx, | |||
| InvokeCallback callback, long timeoutMs) { | |||
There was a problem hiding this comment.
建议参考原有代码规范，添加 final 关键字
| future.cancel(true); | ||
| throw new RemotingException(t); | ||
| } | ||
| } |
There was a problem hiding this comment.
这个格式是由mvn clean compile格式化的，需要复原吗？
| // NO-OP | ||
| } | ||
| }); | ||
| } |
fengjiachun
reviewed
Oct 17, 2022
| <artifactId>grpc-stub</artifactId> | ||
| <version>1.17.0</version> | ||
| <scope>compile</scope> | ||
| </dependency> |
There was a problem hiding this comment.
为什么 jraft-core 需要依赖 grpc？ 应该是 rpc_grpc-impl 依赖吧？
| * | ||
| * @author HH | ||
| */ | ||
| public class UnSupportException extends Exception{ |
There was a problem hiding this comment.
| * @return request stream observer. | ||
| */ | ||
| default StreamObserver<Message> invokeBidiStreaming(final Endpoint endpoint, final Object request, final InvokeCallback callback, | ||
| final long timeoutMs) { |
| catch (final UnSupportException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| return null; |
|
代码质量未达预期，先关闭了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes
If there is no issue then describe the changes introduced by this PR.