Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sofatutor specific changes #1

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

Sofatutor specific changes #1

wants to merge 75 commits into from

Conversation

mfittko
Copy link

@mfittko mfittko commented Sep 10, 2024

Title

Relevant issues

Type

πŸ†• New Feature
πŸ› Bug Fix
🧹 Refactoring
πŸ“– Documentation
πŸš„ Infrastructure
βœ… Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

@mfittko mfittko self-assigned this Sep 10, 2024
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 10, 2024 14:25 Pending
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 10, 2024 14:29 Pending
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 10, 2024 14:33 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 10, 2024 14:50 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 10, 2024 14:57 Inactive
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 11, 2024 06:42 Pending
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 11, 2024 06:49 Pending
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 11, 2024 06:52 Pending
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 11, 2024 06:56 Pending
@github-actions github-actions bot requested a deployment to gh-855215046-pr-1 September 11, 2024 07:38 Pending
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 11, 2024 07:40 Inactive
@@ -639,6 +641,15 @@ def _success_handler_helper_fn(
)
)
else: # streaming chunks + image gen.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is added for the assistants api endpoints

@@ -1134,12 +1142,20 @@ def success_handler(
end_time=end_time,
print_verbose=print_verbose,
)
elif self.model_call_details.get("log_event_type") == "successful_api_call":
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for assistants api logging

model_id=model_id,
cache_key=cache_key,
api_base=api_base,
version=version,
model_region=getattr(user_api_key_dict, "allowed_model_region", ""),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-add?

@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 07:31 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 07:34 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 10:35 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 19:51 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 19:59 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 20:21 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 18, 2024 20:25 Inactive
@github-actions github-actions bot temporarily deployed to gh-855215046-pr-1 September 24, 2024 19:20 Inactive
@mfittko mfittko removed the preview label Nov 4, 2024
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert, not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant