Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] InfoSection 컴포넌트에서 InfoSectionDot의 위치가 적용이 안되던 문제 해결 #34

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

minani-0621
Copy link
Contributor

✅ 구현사항

  • InfoSection에 InfoSectionDot의 위치가 적용이 안되던 문제를 리팩토링을 통해 해결
스크린샷 2024-08-13 오후 12 20 57

InfoSection 리팩토링 코드 부분

const InfoSectionDot = ({
  top,
  bottom,
  left,
  right,
}: InfoSectionDotProps) => {
  const style: React.CSSProperties = {
    width: "20px",
    position: "absolute",
    zIndex: 10,
    ...(top !== undefined && { top: `${top}px` }),
    ...(bottom !== undefined && { bottom: `${bottom}px` }),
    ...(left !== undefined && { left: `${left}px` }),
    ...(right !== undefined && { right: `${right}px` }),
  };

스프레드 연산자를 사용하여 지정된 top, bottom, left, right를 동적으로 적용

@minani-0621 minani-0621 changed the title fix: InfoSection 컴포넌트에서 InfoSectionDot의 위치가 적용이 안되던 문제 해결 (CC-146) [Fix] InfoSection 컴포넌트에서 InfoSectionDot의 위치가 적용이 안되던 문제 해결 (CC-146) Aug 13, 2024
Copy link
Collaborator

@Dunkkkk Dunkkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~

@Dunkkkk Dunkkkk merged commit 0aec995 into develop Aug 13, 2024
1 check passed
@Dunkkkk Dunkkkk deleted the CC-146 branch August 13, 2024 05:53
@minani-0621 minani-0621 added the Fix fix label Aug 13, 2024
@minani-0621 minani-0621 changed the title [Fix] InfoSection 컴포넌트에서 InfoSectionDot의 위치가 적용이 안되던 문제 해결 (CC-146) [Fix] InfoSection 컴포넌트에서 InfoSectionDot의 위치가 적용이 안되던 문제 해결 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants