[Feat] 숨은 캐스퍼 찾기 랜딩페이지 네트워크 연결 및 퍼블리싱 일부 변경 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minani-0621
reviewed
Aug 14, 2024
| @@ -40,7 +40,7 @@ const LadingPageTitle = ({ onClick }: LadingPageTitleProps) => { | |||
| }; | |||
| return ( | |||
| <> | |||
| <div className="flex w-full h-[115vh] justify-center items-center relative"> | |||
| <div className="flex w-full h-[93vh] justify-center items-center relative"> | |||
There was a problem hiding this comment.
height를 93vh로 바꾸면서 공유 버튼 클릭 시 뜨는 애니메이션 위치와 findGameTitleBackground 이미지의 위치 조정이 좀 더 필요할 것 같네요. 이건 제가 이어서 고치겠습니당
minani-0621
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.