[feat] 어드민 기대평 페이지 구현 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
lybell-art
approved these changes
Aug 16, 2024
| setCheckedComments, | ||
| }) { | ||
| const num = checkedComments.size; | ||
| const mutation = useMutation(eventId, () => |
There was a problem hiding this comment.
eventId 자체는 다른 useQuery 또는 useMutation에서 중복될 수 있는 값이므로, 고유한 자원을 위해 "admin-comment-(eventId)" 같은 걸로 바꾸면 좋을 겁니다.
Comment on lines
32
to
44
| const deleteConfirmModal = ( | ||
| <ConfirmModal | ||
| title="삭제" | ||
| description={ | ||
| <> | ||
| <span>이 동작은 다시 돌이킬 수 없습니다.</span> | ||
| <br /> | ||
| <span>{num}개의 이벤트를 삭제하시겠습니까?</span> | ||
| </> | ||
| } | ||
| onConfirm={mutation} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
공통 컴포넌트를 사용하시는 거 좋습니다.
| str += String.fromCharCode(randomCode); | ||
| } | ||
|
|
||
| return str; |
Comment on lines
+23
to
+35
| function getDate(createdAt) { | ||
| const yy = createdAt.slice(2, 4); | ||
| const mm = createdAt.slice(5, 7); | ||
| const dd = createdAt.slice(8, 10); | ||
| return `${yy}-${mm}-${dd}`; | ||
| } | ||
|
|
||
| function getTime(createdAt) { | ||
| const hh = createdAt.slice(11, 13); | ||
| const mm = createdAt.slice(14, 16); | ||
| const ss = createdAt.slice(17, 19); | ||
| return `${hh}:${mm}:${ss}`; | ||
| } |
There was a problem hiding this comment.
이 부분은 순수 함수기 때문에 컴포넌트 바깥쪽으로 빼는 게 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용