Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reregister-command #7

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat: reregister-command #7

merged 3 commits into from
Dec 26, 2023

Conversation

peam1146
Copy link
Member

No description provided.

@peam1146 peam1146 requested a review from saenyakorn December 26, 2023 05:47
Copy link

changeset-bot bot commented Dec 26, 2023

🦋 Changeset detected

Latest commit: 79e970e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@softnetics/what-is-dis Minor
@example/bun-simple-bot Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@saenyakorn saenyakorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont foget well-described changeset

packages/what-is-dis/src/bot/index.ts Outdated Show resolved Hide resolved
@saenyakorn
Copy link
Member

Or jus remove private from registerSlashCommands method

@peam1146 peam1146 requested a review from saenyakorn December 26, 2023 05:54
Copy link
Member

@saenyakorn saenyakorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

.changeset/three-berries-impress.md Show resolved Hide resolved
@peam1146 peam1146 merged commit 7d777e3 into main Dec 26, 2023
1 check passed
@peam1146 peam1146 deleted the feat/reregister-command branch December 26, 2023 05:55
@github-actions github-actions bot mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants