Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support detox in bare react native projects #66

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

km1chno
Copy link
Contributor

@km1chno km1chno commented Aug 22, 2024

Resolves #65

The new UI part are prompts:

Zrzut ekranu 2024-08-22 o 11 30 15

Zrzut ekranu 2024-08-22 o 11 29 40

@km1chno km1chno requested a review from maciekstosio August 22, 2024 09:31
@km1chno km1chno self-assigned this Aug 22, 2024
@maciekstosio
Copy link
Collaborator

Could we make a links clickable? For example with https://www.npmjs.com/package/terminal-link

@km1chno
Copy link
Contributor Author

km1chno commented Aug 23, 2024

The thing with clickable links is great, I didn't know things like this are possible:D I will definitely use them

Update:

I tried to implement them and now I think it's not that black and white. Not all terminals support hyperlinks like that so we would have to check for it. It is doable, for example with https://github.com/jamestalmage/supports-hyperlinks. But even when the terminal supports it (for example iTerm2 on which I tested it), it still was not obvious for me how to click on it 😄 Because in iTerm you have to click on it with CMD/CTRL pressed, and I had to google it.

So I think this is not obvious from UX perspective. I created draft issue for this, I'd leave it for the future after some more consideration: https://github.com/orgs/software-mansion-labs/projects/12/views/1?pane=issue&itemId=76154457

@km1chno km1chno merged commit a9319c3 into main Aug 26, 2024
3 checks passed
@km1chno km1chno deleted the @km1chno/feat-support-detox-outside-expo branch August 26, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Detox in bare React Native
2 participants