-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test_impersonate_account
test to tests_on_networks
#1481
Move test_impersonate_account
test to tests_on_networks
#1481
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1481 +/- ##
===============================================
- Coverage 96.97% 92.85% -4.13%
===============================================
Files 93 107 +14
Lines 4766 5497 +731
===============================================
+ Hits 4622 5104 +482
- Misses 144 393 +249
|
This reverts commit 20c7313.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in client_test.py
, fixtures.py
and trace_api_test.py
were added to fix linting.
test_impersonate_account
test to tests_on_networks
test_impersonate_account
test to tests_on_networkstest_impersonate_account
test to tests_on_networks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that all tests from starknet_py/tests/e2e/client_devnet/account_impersonate_test.py
should be moved to
starknet_py/tests/e2e/tests_on_networks/client_devnet/account_impersonate_test.py
.
Also all fixtures related with fork
or f_
prefix from starknet_py/tests/e2e/client_devnet/fixtures
should be moved, because I suppose that in can generate error during setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1480
Introduced changes
test_impersonate_account
test totests_on_networks