Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_impersonate_account test to tests_on_networks #1481

Merged

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Sep 8, 2024

Closes #1480

Introduced changes

  • Move test_impersonate_account test to tests_on_networks

  • This PR contains breaking changes

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (345b0ba) to head (a35bbad).
Report is 58 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1481      +/-   ##
===============================================
- Coverage        96.97%   92.85%   -4.13%     
===============================================
  Files               93      107      +14     
  Lines             4766     5497     +731     
===============================================
+ Hits              4622     5104     +482     
- Misses             144      393     +249     
Files with missing lines Coverage Δ
starknet_py/conftest.py 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

Copy link
Collaborator Author

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in client_test.py, fixtures.py and trace_api_test.py were added to fix linting.

@franciszekjob franciszekjob changed the title Move devnet client tests to network tests Move test_impersonate_account test to tests_on_networks Sep 9, 2024
@franciszekjob franciszekjob changed the title Move test_impersonate_account test to tests_on_networks Move test_impersonate_account test to tests_on_networks Sep 9, 2024
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that all tests from starknet_py/tests/e2e/client_devnet/account_impersonate_test.py should be moved to
starknet_py/tests/e2e/tests_on_networks/client_devnet/account_impersonate_test.py.

Also all fixtures related with fork or f_ prefix from starknet_py/tests/e2e/client_devnet/fixtures should be moved, because I suppose that in can generate error during setup.

docs/development.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LeLGTM

@franciszekjob franciszekjob merged commit 9c34c01 into development Sep 9, 2024
10 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1480-move-devnet-client-tests branch September 9, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some client_devnet tests to tests_on_networks
2 participants