Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signer tests #1488

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Refactor signer tests #1488

merged 4 commits into from
Sep 12, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Sep 12, 2024 •
edited
Loading

Closes #1219

Introduced changes

Refactor LedgerSigner and StarkCurveSigner tests

  • Update transaction versions to v3
  • Use mocked transactions instead of actual transactions

  • This PR contains breaking changes

ddoktorski
ddoktorski approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@franciszekjob franciszekjob merged commit bf91319 into development Sep 12, 2024
10 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1219-refactor-signer-tests branch September 12, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

Assignees

@franciszekjob franciszekjob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests
2 participants
@franciszekjob @ddoktorski