first stab at using retrypolicies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry I'm just seeing this now @mosesn ! Ill have a closer look this weekend. |
|
this pull request is pretty wrong, actually. we probably want to use the finagle retry policy, not the util-zk retrypolicy, and I commented out an sbt plugin that I shouldn't have. I'll also try to fix it this weekend, but it's probably not worth looking at until I get a chance to push a new version. |
|
So I have a working version, but it's not up to snuff. The big problem is that the finagle-core retrypolicy is very different from the retries or util-zk. I think I can get it to a good place, but it's going to take some thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@softprops, I remember you said that util-zk retrypolicies would need to be augmented to retry on configurable exceptions, but I don't remember which exceptions those were now . . . how does it work?