Fix baseline alignment #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-weindel
force-pushed
the
fix/baseline-alignment
branch
from
08ecffb to
b95a98f
Compare
frank-weindel
added a commit
to lightning-js/msdf-generator
that referenced
this pull request
Apr 22, 2024
- Converted to TypeScript / NodeJS - More detailed documentation - Adjustments made to SDF JSON data - Fixes an [issue](soimy/msdf-bmfont-xml#93) I've discovered in the generated JSON data from [msdf-bmfont-xml](https://github.com/soimy/msdf-bmfont-xml). That project does not seem to be actively maintained anymore so this is a stop gap until that fix can be accepted and released. Planning on some more updates that could provide better metrics for alignment / line height for the SDF text renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the
common.baseproperty does not actually line up with the baseline of the SDF glyphs when they are laid out according to theyoffsetof each glyph. This seems related to the distance range "pad" that is added to both the baseline and theyoffsetfor each glyph.Baseline Adjustment
I don't think that the baseline itself needs the pad added to it as the distance range itself should not generally affect where the glyph is actually drawn (unless a user opts to render glyphs thicker or thinner than the original font).
Y-Offset Adjustment
Just like its done for the
xoffsetalready, the pad foryoffsetis subtracted from the bBox value instead of added.Before Change
After Change