Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TGS] DMAPI update to 7.3.0 + discord config #5880

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

Phoenix4O4
Copy link
Contributor

Updated DMAPI to version 7.3.0

  1. Relaying Client Count to TGS: Added support for relaying the current client count back to TGS during health checks. (Fix DMAPI documentation comment typos tgstation/tgstation-server#1854)
  2. Fixed a typo in documentation comments. (Fix DMAPI documentation comment typos tgstation/tgstation-server#1854)
  3. Fixed Discord documentation links. (DMAPI v7.2.0 tgstation/tgstation-server#1853)
  4. Used IETF RFC 2119 wording in documentation. (DMAPI v7.2.0 tgstation/tgstation-server#1853)
  5. Populated comments for previously undocumented public entities. (DMAPI v7.2.0 tgstation/tgstation-server#1853)
  6. Fixed a grammar mistake in comments. (v6.7.0 tgstation/tgstation-server#1829)
  7. Added consumer APIs for overriding the HTTP GET implementation. (DMAPI v7.2.0 tgstation/tgstation-server#1853)
  8. Added debug log statements. (v6.7.0 tgstation/tgstation-server#1829)

Customizable Round Messages:

  1. Added support for customizing the start and end round messages through configuration files, eliminating the need to modify the code directly.
  2. Example use case: Specify a role ID in the end-round message to notify players and allow them to prepare for the next round.

Here’s an example of how the new customizable round messages can be configured in config/example/discord.txt:

## Welcome message sent at the start of a new round.
## Example of a notification message: "A new round has begun!"
MESSAGE_ANNOUNCE_NEW_GAME Round A new round has begun!

## Message sent at the end of a round.
## Example of a role notification message: "<@&859887924223672360> The round is almost over! Get ready for the next one."
## Replace 859887924223672360 with the appropriate role ID if needed.
MESSAGE_ANNOUNCE_ROUND_END <@&859887924223672360> The round is almost over! Get ready for the next one.

Changelog

@Smokingsquirrel
Copy link
Contributor

Since I have no idea about deeper code workings, what does this essentially mean for a player? Or is this all server frameworks?

@Phoenix4O4
Copy link
Contributor Author

Since I have no idea about deeper code workings, what does this essentially mean for a player? Or is this all server frameworks?

For a player, almost nothing changes. It's primarily an integration with the TGS-API. The only noticeable difference for the player will be a message in discord about the end of the round.

@Trilbyspaceclone Trilbyspaceclone added Documentation Improvements or additions to documentation Bug-Fix Fixes issues Port A RP mirrored or converted from a different repo labels Nov 26, 2024
@Trilbyspaceclone Trilbyspaceclone merged commit 00ce979 into sojourn-13:master Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Fix Fixes issues Documentation Improvements or additions to documentation Port A RP mirrored or converted from a different repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants