Update Codama to 1.2.4 and use Codama CLI #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates Codama and its renderers to the latest versions. It also uses the new Codama CLI to render the clients of the System program.
lorisleiva
commented
Feb 3, 2025
Comment on lines
+22
to
+23
| solana-client = { version = "^2.1", optional = true } | ||
| solana-sdk = { version = "^2.1", optional = true } |
There was a problem hiding this comment.
Note that we are currently having to use these crates instead of the more granular ones to stay compatible with clients using Solana below 2.1.
We have documented a way forward on the Codama Rust renderer here.
lorisleiva
changed the title
joncinque
approved these changes
Feb 3, 2025
Comment on lines
+67
to
+69
| let accounts = rpc | ||
| .get_multiple_accounts(&addresses) | ||
| .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e.to_string()))?; |
There was a problem hiding this comment.
Some RPCs meter the get_multiple_accounts call differently than the normal get_account_info, so it might be worth avoiding get_multiple_accounts for just one input
There was a problem hiding this comment.
Ah good to know. This is something that would needs updating on the Rust renderer (was introduced in this PR). I made an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Codama and its renderers to the latest versions.
It also uses the new Codama CLI to render the clients of the System program.