Add streaming type definitions #121
Draft
+296
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milomg
reviewed
Sep 28, 2022
| editor: monaco.editor.ICodeEditor, | ||
| ): Promise<void> { | ||
| if (LOADED) { | ||
| return; |
There was a problem hiding this comment.
I believe this changes semantics... I thought we needed to wireTmGrammars to every new editor instance (i.e. toggling output code tab)
There was a problem hiding this comment.
I don't recall having to wire it all the time, but if it does cause issues then we can remove the guard
milomg
reviewed
Sep 28, 2022
| 'source.css': 'css', | ||
| 'source.js': 'jsx', | ||
| // 'source.js': 'javascript', | ||
| 'source.js.jsx': 'jsx', |
There was a problem hiding this comment.
Is this used? Edit: nvm, I see above, but why not just make 'javascript' also map to source.tsx?
There was a problem hiding this comment.
TBF we can just remove it. jsx and tsx has different grammars.
milomg
reviewed
Sep 28, 2022
| function createRegistry(): Registry { | ||
| return new Registry({ | ||
| getGrammarDefinition: async (scopeName) => { | ||
| console.log(scopeName); |
There was a problem hiding this comment.
yeah I forgot to remove this 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.