Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mismatched dependency issues #182

Closed
wants to merge 1 commit into from
Closed

Conversation

mdynnl
Copy link

@mdynnl mdynnl commented Aug 14, 2024

By using ?external, this PR should solve most of the mismatched dependency issues caused by esm.sh's static build.

@milomg
Copy link
Member

milomg commented Aug 18, 2024

I would prefer if this were generic to all dependencies, but a brief glance at esm.sh doesn't reveal an easy way to do it automatically (I'd rather not just mark all keys as external for all packages because we'd get quadratic blowup and things would be less editable). Before I merge this, do you have any ideas that I should explore in that direction?

Update: Maybe https://jspm.org/docs/generator/stable/?

@mdynnl
Copy link
Author

mdynnl commented Aug 18, 2024

@mdynnl
Copy link
Author

mdynnl commented Aug 18, 2024

#183

It's still possible with esm.sh too, take this for example https://esm.sh/@solid-primitives/memo?external=@solid-primitives/memo,solid-js but we'll have to put every deps there so not really suitable.

@mdynnl
Copy link
Author

mdynnl commented Aug 26, 2024

closed in favor of #183

@mdynnl mdynnl closed this Aug 26, 2024
@mdynnl mdynnl deleted the legacy branch August 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants