-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce flat routing #1482
base: main
Are you sure you want to change the base?
Reintroduce flat routing #1482
Conversation
🦋 Changeset detectedLatest commit: 59094aa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
One thing I wasn't sure about here was what this did for people who wanted |
Looks like Remix use |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Changes to nested route escaping in RC0 broke what was essentially flat routing, where files/folders named along the lines of
a.b.c
would have their path becomea/b/c
. This is useful for reducing folder nested. Whether it was an intentional behaviour previously I'm not sure, but I'd like it to be there.What is the new behavior?
Adds back the
. -> /
regex that was removed in RC0, bringing back flat route support.Other information
Having flat routing alongside nested routing does add the potential for multiple definitions of the same route, but IMO the convenience outweighs that risk