Fix test config #200
Merged
Fix test config #200
+535
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31d8de3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
@pedro00dk thanks! can you add a changeset |
|
can you add a CI flow that run the vitest tests? |
|
Hi, I can do that. |
|
I mostly use gitlab, I don't know much about github CI though. |
|
CI first try lul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying my text from discord:
Hi,
I updated to the latest version of vite-plugin-solid (2.11.4) and I believe it is broken.
I'm using Vitest 3 (alrady dealing with the issue from the previous version, not being able to use instances).
After updating to the new version I'm having a different issue, every time I run vitest it asks me to install jsdom.
Even though I have a test.environment = 'node' in my vite configuration.
I had a look at one of the patches and I think I found the issue.
https://github.com/solidjs/vite-plugin-solid/pull/183/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R222
In the previous version, the code checked for test.environment being not set, where test is vite's userConfig.test
In the new version it is checking for userTest.environment not being set, however, userTest is userConfig, not userConfig.test.
The code is checking the wrong object, same in line 218 for setupFiles.
I'm a bit tired to write an issue right now, too late...
Changes:
example/vite-6to use vitest browser mode and vitestLocatorandexpectAPIs.