Add Ruby 3.4 support #6117
Merged
Add Ruby 3.4 support #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ruby 3.4 the csv library is it's own gem
tvdeyen
added
changelog:solidus_legacy_promotions
jarednorman
approved these changes
Feb 12, 2025
Ruby 3.4 finally adds the new has key syntax into inspect. Since we still support older Ruby versions we just remove the expectation of the hash key.
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6117 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 830 830
Lines 18013 18013
=======================================
Hits 15975 15975
Misses 2038 2038 ☔ View full report in Codecov by Sentry. |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to add
csvbecause it has been extracted into a separate gem.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: